[U-Boot] [RFC] PPC: post_word_{load/store} - eliminate redundant code

Michael Zaidman michael.zaidman at gmail.com
Thu Apr 22 11:27:56 CEST 2010


On Thu, Apr 22, 2010 at 12:03 PM, Wolfgang Denk <wd at denx.de> wrote:
>>
>> > Looking at the code I wonder why we need post_word_store() and
>> > post_word_load() functions at all. All implementations I have found
>> > translate into a single ioread32() resp. iowrite32() call.
>> >
>> Probably, due to big and little endians that the PPC code should
>> support. On other hand, AFAIK, no one is really using a little endian
>> notation on PPC platforms in u-boot. I am not sure however, is this a
>> good enough reason to omit such support? Or am I missing something?
>
> We don;t indterface to any specific device register here, so the
> actual byte order used when writing and reading the data does not
> matter at all (as long as writer and reader agree). I see no reason
> why we should not simply use the respective accessor macro for this
> architecture.
>
Ah, of course, that's correct.

Thanks,
Michael


More information about the U-Boot mailing list