[U-Boot] [PATCH 6/7] PXA: Add initial Palm LifeDrive support

[Wolfgang Denk]

Dear Marek Vasut,

In message <1279811005-21858-6-git-send-email-marek.vasut at gmail.com> you wrote:
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  board/palmld/Makefile        |   54 ++++++++
>  board/palmld/config.mk       |    1 +
>  board/palmld/lowlevel_init.S |   46 +++++++
>  board/palmld/palmld.c        |   81 ++++++++++++
>  board/palmld/u-boot.lds      |   56 +++++++++
>  boards.cfg                   |    1 +
>  include/configs/palmld.h     |  275 ++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 514 insertions(+), 0 deletions(-)
>  create mode 100644 board/palmld/Makefile
>  create mode 100644 board/palmld/config.mk
>  create mode 100644 board/palmld/lowlevel_init.S
>  create mode 100644 board/palmld/palmld.c
>  create mode 100644 board/palmld/u-boot.lds
>  create mode 100644 include/configs/palmld.h

Entries to MAINTAINERS and MAKEALL missing.

> diff --git a/board/palmld/Makefile b/board/palmld/Makefile
> new file mode 100644
> index 0000000..c184cf6
> --- /dev/null
> +++ b/board/palmld/Makefile
> @@ -0,0 +1,54 @@
> +
> +#

Don't waste too many empty lines.

> +# Copyright (C) 2009

2009?

[Please see comments for previous patch; seems this one looks pretty
much similar.]


Actually the code looks pretty much similar, too.

Are you sure that multiple copies of htis code are needed?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We want to create puppets that pull their own strings.   - Ann Marion