[U-Boot] [PATCH 7/7] PXA: Vpac270 config fixes

[Wolfgang Denk]

Dear Marek Vasut,

In message <1279811005-21858-7-git-send-email-marek.vasut at gmail.com> you wrote:
> Define __io to get harddrive working.
> Fix saving of environment into OneNAND.
> Boot from harddrive when possible.
> 
> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> ---
>  include/configs/vpac270.h |   12 +++++++++++-
>  1 files changed, 11 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/vpac270.h b/include/configs/vpac270.h
> index 6d02995..a0383b2 100644
> --- a/include/configs/vpac270.h
> +++ b/include/configs/vpac270.h
> @@ -36,7 +36,7 @@
>  /*
>   * Environment settings
>   */
> -#define	CONFIG_ENV_SIZE			0x4000
> +#define	CONFIG_ENV_SIZE			0x20000


Do you really need 128 KiB for environment data? [Note that this is
NOT a sector size or so!]

Really???  I think this is not true.

> +/*
> + * HACK WARNING: __io
> + * This MUST go away once the readb/writeb and inb/outb issue is solved
> + */
> +#define __io

Drop that.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Plan to throw one away. You will anyway."
                              - Fred Brooks, "The Mythical Man Month"