[U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

Remy Bohmer linux at bohmer.net
Fri Aug 13 10:49:22 CEST 2010


Hi,

2010/8/13 Vitaly Kuzmichev <vkuzmichev at mvista.com>:
> Hi Remy,
>
> No, it does not.
> DEBUG is defined as dev_err and dev_err is defined as printf.
> Anyway I can change it.

Please do not top-post!

> On 08/12/2010 10:33 PM, Remy Bohmer wrote:
>>> @@ -37,8 +37,10 @@
>>>  #define dev_err(x, stuff...) printf(stuff)
>>>  #define dev_dbg dev_err
>>>  #define dev_warn dev_err
>>> -#define DEBUG dev_err
>>> -#define VDEBUG DEBUG
>>> +#define WARN INFO
>>> +#define ERROR INFO
>>> +#define DEBUG INFO
>>
>> This switches DEBUG logging on by default. This is not wanted.
>> Can you please change that?

> No, it does not.

Well, I see with this patch much more debug logging then without it...
Hmm, it seems that you replaced all use of dprintf (which is trashed)
by DEBUG()...

> Anyway I can change it.

please do, DEBUG logging should not be on by default...

Kind regards,

Remy


More information about the U-Boot mailing list