[U-Boot] [PATCH 3/8] USB-CDC: Linux-like debug printout

[Wolfgang Denk]

Dear Remy Bohmer,

In message <AANLkTi=gnFZr6wT-RJ6CLFEKuGGhhpJUDbj1VftAR9kX at mail.gmail.com> you wrote:
> 
> >>> +#define WARN INFO
> >>> +#define ERROR INFO
> >>> +#define DEBUG INFO
> >>
> >> This switches DEBUG logging on by default. This is not wanted.
> >> Can you please change that?
> 
> > No, it does not.
> 
> Well, I see with this patch much more debug logging then without it...
> Hmm, it seems that you replaced all use of dprintf (which is trashed)
> by DEBUG()...
> 
> > Anyway I can change it.
> 
> please do, DEBUG logging should not be on by default...

DEBUG is already a well-defined name. Any different use of the same
name will result in the patches being rejected.

Please fix this!

I also object against names like WARN, ERROR and INFO. They are just
too dangerous.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You are an excellent tactician, Captain. You let your second in  com-
mand attack while you sit and watch for weakness.
	-- Khan Noonian Singh, "Space Seed", stardate 3141.9