[U-Boot] [PATCH 6/7] powerpc/qe: supports loading QE firmware from nand flash

[Wolfgang Denk]

Dear Haiying Wang,

In message <1282028890.2814.95.camel at localhost.localdomain> you wrote:
>
> > >  arch/powerpc/cpu/mpc83xx/cpu_init.c |    8 --------
> > >  arch/powerpc/cpu/mpc85xx/cpu_init.c |    8 --------
> > >  arch/powerpc/lib/board.c            |   31 +++++++++++++++++++++++++++++++
> > >  3 files changed, 31 insertions(+), 16 deletions(-)
> > 
> > Please do not throw such stuff into common code. Use board /
> > architecture specific implementations instead (say, provide some
> > misc_init_r() or so).
> QE is not a misc feature for the SOCs with QE. It actually makes more
> sense to enable it in cpu init code. But P1021 doesn't have ROM in QE,
> and P1021mds doesn't have NOR flash on board, so I move this cpu feature
> to board.c. How about re-spin this patch as:

Maybe. But it has no place in arch/powerpc/lib/board.c

>  arch/powerpc/cpu/mpc85xx/cpu_init.c |    2 +-
>  arch/powerpc/lib/board.c            |   15 +++++++++++++++
>  2 files changed, 16 insertions(+), 1 deletions(-)

NAK for the same reason - I don't want to see this in common code like
arch/powerpc/lib/board.c

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"You know, after a woman's raised a family and so on,  she  wants  to
start living her own life."   "Whose life she's _been_ living, then?"
                                  - Terry Pratchett, _Witches Abroad_