[U-Boot] [PATCH] mx51evk: Provide a proper reset for the Ethernet PHY

Fabio Estevam fabioestevam at yahoo.com
Fri Aug 20 16:26:21 CEST 2010


Hi Stefano,

--- On Fri, 8/20/10, Stefano Babic <sbabic at denx.de> wrote:
...

> 
> I know I am responsible for this usage, because I forget to
> add some
> accessors for the gpio pins - as I see your patch, I have
> sent a patch
> to support it. However, a direct access to registers using
> offsets is
> not allowed in u-boot. If we use some kind of accessors,
> your code will
> be easier to read it. Everything could be changed as
> (0X4000 --> gpio
> 46, if I am not wrong):
> 
>     udelay(200);
>     mxc_gpio_set(46);
> 
> What do you think ?

Yes, I agree. Do you plan to send a patch for mx51evk using this approach?

If you do, then I can re-submit my patch after your update.

Regards,

Fabio Estevam



      



More information about the U-Boot mailing list