[U-Boot] [PATCH] Add generic support for samsung s3c2440

[Minkyu Kang]

Dear C Nauman,

On 23 August 2010 22:40, C Nauman <cnauman at diagraph.com> wrote:
> This patch adds generic support for the Samsung s3c2440 processor.
> Started from patch posted 2009-06-19 by
>  Kevin Morfitt. Then modified for changes in the code that have occurred
> since.
>
> Signed-off-by: Craig Nauman <cnauman <at> diagraph.com>

Please fix the email address.
And could you please use the git format-patch?
so that we can see what are changed.

> ---
>
> diff --git a/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h b/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
> index 15f53dd..d4abd24 100644
> --- a/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
> +++ b/arch/arm/include/asm/arch-s3c24x0/s3c24x0.h
> @@ -82,6 +82,10 @@ struct s3c24x0_interrupt {
>        u32     SUBSRCPND;
>        u32     INTSUBMSK;
>  #endif
> +#ifdef CONFIG_S3C2440
> +       u32     SUBSRCPND;
> +       u32     INTSUBMSK;
> +#endif
>  };

We don't allow upper case structure members.
That is reason for why kevin sent clean-up patches.
Please fix it globally.

Thanks.
Minkyu Kang.
-- 
from. prom.
www.promsoft.net