[U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros

[Detlev Zundel]

Hi Timur,

> The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly.  If
> cursor support is disabled, then these macros are defined to nothing, but
> then they are used like this:
>
> 	if (console_col < CONSOLE_COLS)
> 		CURSOR_OFF
> 	console_row++;
>
> which was compiled like this:
>
> 	if (console_col < CONSOLE_COLS)
> 		console_row++;
>
> This is obviously not what was intended.
>
> Signed-off-by: Timur Tabi <timur at freescale.com>

Patch looks good, thanks!

Acked-by: Detlev Zundel <dzu at denx.de>

> ---
>
> This patch depends on
>
> video: cfb_console: add support for 4bpp bitmaps with GDF_32BIT_X888RGB
>
>  drivers/video/cfb_console.c |   24 ++++++++++++++----------
>  1 files changed, 14 insertions(+), 10 deletions(-)

-- 
Man against god... God against Man... Man against nature... Nature against
man...   God against nature...   Nature against god...  a very, very funny
religion.             -- Zen Master D.T. Suzuki commenting on Christianity
--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: dzu at denx.de