[U-Boot] [PATCH] video: cfb_console: fix definition and usage of CURSOR_xxx macros
Anatolij Gustschin
agust at denx.de
Tue Aug 31 01:02:46 CEST 2010
On Fri, 27 Aug 2010 15:45:47 -0500
Timur Tabi <timur at freescale.com> wrote:
> The CURSOR_ON, CURSOR_OFF, and CURSOR_SET macros are defined incorrectly. If
> cursor support is disabled, then these macros are defined to nothing, but
> then they are used like this:
>
> if (console_col < CONSOLE_COLS)
> CURSOR_OFF
> console_row++;
>
> which was compiled like this:
>
> if (console_col < CONSOLE_COLS)
> console_row++;
>
> This is obviously not what was intended.
>
> Signed-off-by: Timur Tabi <timur at freescale.com>
> ---
>
> This patch depends on
>
> video: cfb_console: add support for 4bpp bitmaps with GDF_32BIT_X888RGB
>
> drivers/video/cfb_console.c | 24 ++++++++++++++----------
> 1 files changed, 14 insertions(+), 10 deletions(-)
Applied to u-boot-video/master. Thanks!
Best regards,
Anatolij
More information about the U-Boot
mailing list