[U-Boot] [PATCH 2/4] Use LINK_OFF to access global data

[Joakim Tjernlund]

Wolfgang Denk <wd at denx.de> wrote on 02/01/2010 19:17:52:
>
> Dear Joakim Tjernlund,
>
> in message <OF7EEC72D7.43E7C3B7-ONC125769E.00078331-C125769E.
> 0009144C at transmode.se> you wrote:
> >
> > Happy new year :)
>
> Thanks, and same to you and everybody else.
>
> > The bigger question is if the LINN_OFF changes in general are acceptable to u-boot.
> > Any board/arch that doesn't want this functionality should not notice I think.
>
>
> What's the impact?  So far it seems to me that there are pretty heavy
> changes to lots of global code anyway, so we can then enable it for
> all boards as well. Otherwise we just add a lot of #ifdef's and make
> the code even harder to read and to understand.  Which does not mean
> that I understood what you are doing :-(

We don't have to add #ifdefs. I #defined a version a LINK_OFF for non users
too. That way we don't have to litter the code with #ifdefs and we get
some type checking from gcc too even for boards that don't use it.

I don't think we can enable this for all boards at once, there will be too much that break.
My goal was to get 83xx fully functional and then other boards could
follow.

 Jocke