[U-Boot] [PATCH v4 09/12] SPEAr : Support added for SPEAr300 board

[Tom]

Vipin KUMAR wrote:
> Hello Tom,
> 
>>  include/configs/spear.h         |   25 +++++++++++++++--
>>  6 files changed, 171 insertions(+), 3 deletions(-)
>>  create mode 100755 board/spear/spear300/Makefile
>>  create mode 100755 board/spear/spear300/config.mk
>>  create mode 100755 board/spear/spear300/spear300.c
>>
>> <snip>
>> diff --git a/include/configs/spear.h b/include/configs/spear.h
>> index a625c31..15a8241 100755
>> --- a/include/configs/spear.h
>> +++ b/include/configs/spear.h
>> @@ -28,7 +28,12 @@
>>   * High Level Configuration Options
>>   * (easy to change)
>>   */
>> +#if defined(CONFIG_MK_spear600)
>>  #define CONFIG_SPEAR600                1
>> +#elif defined(CONFIG_MK_spear300)
>> +#define CONFIG_SPEAR3XX                1
>> +#define CONFIG_SPEAR300                1
>> +#endif
>>
>> There should be a config file per board.
>> The common parts can be kept in a separate file
>> So the should be 'spear300.h' etc.
> 
> Is it mandatory ?
> Since there are already some board configs in Makefile
> eg. P2020RDB_config and P1011RDB_config etc
> 
> In fact, I got this comment from Wolfgang on my first patch set
> that these are similar boards and can be combined

Yes similar boards can share the same config.
This is I believe is ok if the board has a slightly different hw
configuration that its siblings. For example using NOR instead of NAND.

A good rule of thumb is, boards with the same machine id should
have the same config file.  Those with different should not.

The split for you would be
spear3xx.h and spear6xx.h

or

spear300.h spear310.h spear320.h spear600.h

or

common-spear.h and then smaller spear*.h files.

Tom

> 
> Regards
> Vipin