[U-Boot] [PATCH v4 09/12] SPEAr : Support added for SPEAr300 board

[Vipin KUMAR]

Hello Tom,

>  include/configs/spear.h         |   25 +++++++++++++++--
>  6 files changed, 171 insertions(+), 3 deletions(-)
>  create mode 100755 board/spear/spear300/Makefile
>  create mode 100755 board/spear/spear300/config.mk
>  create mode 100755 board/spear/spear300/spear300.c
> 
> <snip>
> diff --git a/include/configs/spear.h b/include/configs/spear.h
> index a625c31..15a8241 100755
> --- a/include/configs/spear.h
> +++ b/include/configs/spear.h
> @@ -28,7 +28,12 @@
>   * High Level Configuration Options
>   * (easy to change)
>   */
> +#if defined(CONFIG_MK_spear600)
>  #define CONFIG_SPEAR600                1
> +#elif defined(CONFIG_MK_spear300)
> +#define CONFIG_SPEAR3XX                1
> +#define CONFIG_SPEAR300                1
> +#endif
> 
> There should be a config file per board.
> The common parts can be kept in a separate file
> So the should be 'spear300.h' etc.

Is it mandatory ?
Since there are already some board configs in Makefile
eg. P2020RDB_config and P1011RDB_config etc

In fact, I got this comment from Wolfgang on my first patch set
that these are similar boards and can be combined

Regards
Vipin