[U-Boot] [PATCH] Add support for MB86R01 from Fujitsu

Tom Tom.Rix at windriver.com
Sat Jan 16 16:39:01 CET 2010


Matthias Weisser wrote:
> Signed-off-by: Matthias Weisser <matthias.weisser at graf-syteco.de>
> ---
>  common/serial.c                      |    3 +-
>  cpu/arm926ejs/jade/Makefile          |   47 +++++++++
>  cpu/arm926ejs/jade/reset.c           |   37 ++++++++
>  cpu/arm926ejs/jade/timer.c           |  127 +++++++++++++++++++++++++
>  include/asm-arm/arch-jade/hardware.h |   31 ++++++
>  include/asm-arm/arch-jade/jade.h     |  170 ++++++++++++++++++++++++++++++++++
>  include/serial.h                     |    3 +-
>  7 files changed, 416 insertions(+), 2 deletions(-)
>  create mode 100644 cpu/arm926ejs/jade/Makefile
>  create mode 100644 cpu/arm926ejs/jade/reset.c
>  create mode 100644 cpu/arm926ejs/jade/timer.c
>  create mode 100644 include/asm-arm/arch-jade/hardware.h
>  create mode 100644 include/asm-arm/arch-jade/jade.h
> 
> diff --git a/common/serial.c b/common/serial.c
> index 5f9ffd7..7397608 100644
> --- a/common/serial.c
> +++ b/common/serial.c
> @@ -41,7 +41,8 @@ struct serial_device *__default_serial_console (void)
>  #elif defined(CONFIG_405GP) || defined(CONFIG_405CR) || defined(CONFIG_440) \
>     || defined(CONFIG_405EP) || defined(CONFIG_405EZ) || defined(CONFIG_405EX) \
>     || defined(CONFIG_MPC5xxx) || defined(CONFIG_MPC83xx) \
> -   || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx)
> +   || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) \
> +   || defined(CONFIG_JADE)
>  #if defined(CONFIG_CONS_INDEX) && defined(CONFIG_SYS_NS16550_SERIAL)
>  #if (CONFIG_CONS_INDEX==1)
>  	return &eserial1_device;

Including serial here is premature.
I do not see where you set up there serial devices.
Please save this for a later serial-only patch.

Otherwise this patch looks fine.
Tom


More information about the U-Boot mailing list