[U-Boot] [PATCH] Add support for MB86R01 from Fujitsu

[Matthias Weißer]

Am 16.01.2010 16:39, schrieb Tom:
> Matthias Weisser wrote:
>> @@ -41,7 +41,8 @@ struct serial_device *__default_serial_console (void)
>>   #elif defined(CONFIG_405GP) || defined(CONFIG_405CR) || defined(CONFIG_440) \
>>      || defined(CONFIG_405EP) || defined(CONFIG_405EZ) || defined(CONFIG_405EX) \
>>      || defined(CONFIG_MPC5xxx) || defined(CONFIG_MPC83xx) \
>> -   || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx)
>> +   || defined(CONFIG_MPC85xx) || defined(CONFIG_MPC86xx) \
>> +   || defined(CONFIG_JADE)
>>   #if defined(CONFIG_CONS_INDEX)&&  defined(CONFIG_SYS_NS16550_SERIAL)
>>   #if (CONFIG_CONS_INDEX==1)
>>   	return&eserial1_device;
>
> Including serial here is premature.
> I do not see where you set up there serial devices.
> Please save this for a later serial-only patch.

Well, the SoC has UARTs which are fully compatible with the ns16550 
driver (drivers/serial/serial.c) and therefore I simply set it up like 
this. What would be the right way to do it? I don't see a reason to add 
a serial_mb860x.c driver which is virtually identical to the current 
stuff in serial.c

> Otherwise this patch looks fine.

Thanks for checking.

Regards,
Matthias