[U-Boot] [PATCH v4 0/6] Add support for TI OMAP4 SDP and Panda

[Steve Sakoman]

On Thu, 2010-07-01 at 09:45 -0500, Paulraj, Sandeep wrote:
> 
> > 
> > On Wed, 2010-06-30 at 14:38 -0500, Paulraj, Sandeep wrote:
> > >
> > > >
> > > > This is version 4, which takes into account all feedback to date, and
> > has
> > > > been rebased on the next branch.
> > > >
> > > > The folowing series adds support for two boards based upon the TI
> > > > OMAP4430.  The OMAP4430 is a Cortex-A9 based SOC from TI.
> > <snip>
> > >
> > > I ran MAKEALL for ARMV7 and I got several compile errors.
> > >
> > > I have setup a testing branch for you(u-boot-ti/testing) with all the
> > patches applied.
> > >
> > > Please fix and resubmit.
> > 
> > I'm not quite sure what went awry here, but the compile errors are
> > caused by the fix you did to the mmc patch.  Perhaps due to applying the
> > patches out of order in your testing branch??
> > 
> > In any event, the patches seem to work here applied to the current
> > master/next in the original order.
> > 
> > Here's a pointer to my working git branch:
> > 
> > http://www.sakoman.com/cgi-bin/gitweb.cgi?p=u-
> > boot.git;a=shortlog;h=refs/heads/omap4-next-upstream
> > 
> > I added your "Signed-off-by" in case you wanted to just do a pull.  But
> > I am also happy to resubmit the patches if you prefer that.
> > 
> > Regards,
> > 
> > Steve
> >
> 
> This is what I get. I think the recent changes in Makefile are also resulting in 2 of these.

Yes, I don't think that the 2 errors are related to my patches
(am3517_evm_config and s5p_goni_config).  Neither of those boards seem
to have made it into boards.cfg

Is this something that you want me to submit a fix patch for, or are
those board maintainers going to handle this?

The two warnings are also not caused by my patch, that issue has always
been there for any board that defines CMD_MMC and
CONFIG_SYS_MMC_SET_DEV.  Granted, no boards up to now make use of that
feature :-)

I think the solution is simply to add a prototype for the mmc_set_dev
function to mmc.h

I can do this as a separate fixit patch unrelated to my series, or I can
add it to the "OMAP: mmc: add support for second and third mmc channels"
and resubmit the patch series.  The latter might make sense since my two
boards are the first to actually make use of the CONFIG_SYS_MMC_SET_DEV
functionality.

Which would you prefer?

Steve




> a0866907 at gt9szxw61 u-boot-denx]$ CROSS_COMPILE=arm-none-linux-gnueabi- MAKEALL ARMV7
> make: *** No rule to make target `am3517_evm_config'.  Stop.
> make: *** [am3517_evm_config] Error 1
> System not configured - see README
> make: *** [all] Error 1
> arm-none-linux-gnueabi-size: './u-boot': No such file
> Configuring for devkit8000 board...
>    text    data     bss     dec     hex filename
>  193334   10164  214484  417982   660be ./u-boot
> Configuring for mx51evk board...
>    text    data     bss     dec     hex filename
>  123610    4956  216924  345490   54592 ./u-boot
> Configuring for omap3_beagle board...
>    text    data     bss     dec     hex filename
>  184227   10036  202432  396695   60d97 ./u-boot
> Configuring for omap3_overo board...
>    text    data     bss     dec     hex filename
>  174655    9724  210440  394819   60643 ./u-boot
> Configuring for omap3_evm board...
>    text    data     bss     dec     hex filename
>  203347    9584  257708  470639   72e6f ./u-boot
> Configuring for omap3_pandora board...
>    text    data     bss     dec     hex filename
>  158134    9292  200544  367970   59d62 ./u-boot
> Configuring for omap3_sdp3430 board...
>    text    data     bss     dec     hex filename
>  159173    5010  214832  379015   5c887 ./u-boot
> Configuring for omap3_zoom1 board...
>    text    data     bss     dec     hex filename
>  172573    9748  201616  383937   5dbc1 ./u-boot
> Configuring for omap3_zoom2 board...
>    text    data     bss     dec     hex filename
>  144311    8532  200396  353239   563d7 ./u-boot
> Configuring for omap4_panda board...
> cmd_mmc.c: In function 'do_mmc':
> cmd_mmc.c:70: warning: implicit declaration of function 'mmc_set_dev'
>    text    data     bss     dec     hex filename
>  100853    4580  200036  305469   4a93d ./u-boot
> Configuring for omap4_sdp4430 board...
> cmd_mmc.c: In function 'do_mmc':
> cmd_mmc.c:70: warning: implicit declaration of function 'mmc_set_dev'
>    text    data     bss     dec     hex filename
>  100850    4580  200036  305466   4a93a ./u-boot
> make: *** No rule to make target `s5p_goni_config'.  Stop.
> make: *** [s5p_goni_config] Error 1
> System not configured - see README
> make: *** [all] Error 1
> arm-none-linux-gnueabi-size: './u-boot': No such file
> Configuring for smdkc100 board...
>    text    data     bss     dec     hex filename
>  150434    7884  221668  379986   5cc52 ./u-boot
> 
> --------------------- SUMMARY ----------------------------
> Boards compiled: 14
> Boards with warnings or errors: 4 ( am3517_evm omap4_panda omap4_sdp4430 s5p_goni )
>