[U-Boot] [PATCH v2] 83xx: add support for ve8313 board

Wolfgang Denk wd at denx.de
Wed Jul 7 11:11:24 CEST 2010


Dear Heiko Schocher,

In message <4C343AE3.7060804 at denx.de> you wrote:
> 
> >> +#ifdef CONFIG_TSEC1
> >> +#define CONFIG_HAS_ETH0
> >> +#define CONFIG_TSEC1_NAME      "TSEC0"
> > 
> > Oops? This is TSEC1, so why do you name it "TSEC0" ?
> 
> Because this is so in all other board configs I looked.
> 
> Kim? Can you comment this?
> (I think it is because to be in sync with "eth0" ...)

That is not a good reason to confuse the users. TSEC0 and TSEC1 are
different interfaces, and to bend names is definitely a bad idea.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The trouble with our times is that the future is not what it used  to
be.                                                     - Paul Valery


More information about the U-Boot mailing list