[U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support
Albert ARIBAUD
albert.aribaud at free.fr
Mon Jul 12 08:14:15 CEST 2010
Hi Prafulla,
Le 12/07/2010 08:00, Prafulla Wadaskar a écrit :
>> +/*
>> + * Ethernet
>> + */
>
> Pls remove additional space char here
Done.
>> +#define CONFIG_MV_EGIGA /* Enable Marvell egiga
>> [...]
>> +#define CONFIG_RESET_PHY_R /* use reset_phy() to init
>> mv8831116 PHY */
>
> Shift above definition below (inside #ifdef CONFIG_CMD_NET), that makes more sense
Done--actually replaced "Ethernet" with "Network" in block comment as
the whole block is not only about Eth.
Thanks for the feedback.
Any remaining comments on patches 1-4?
Amicalement,
--
Albert.
More information about the U-Boot
mailing list