[U-Boot] [PATCH V3 5/5] edminiv2: add ethernet support
Ben Warren
biggerbadderben at gmail.com
Mon Jul 12 08:31:06 CEST 2010
Hi Albert,
On 7/11/2010 11:14 PM, Albert ARIBAUD wrote:
> Hi Prafulla,
>
> Le 12/07/2010 08:00, Prafulla Wadaskar a écrit :
>
>>> +/*
>>> + * Ethernet
>>> + */
>> Pls remove additional space char here
> Done.
>
>>> +#define CONFIG_MV_EGIGA /* Enable Marvell egiga
>>> [...]
>>> +#define CONFIG_RESET_PHY_R /* use reset_phy() to init
>>> mv8831116 PHY */
>> Shift above definition below (inside #ifdef CONFIG_CMD_NET), that makes more sense
> Done--actually replaced "Ethernet" with "Network" in block comment as
> the whole block is not only about Eth.
>
> Thanks for the feedback.
>
> Any remaining comments on patches 1-4?
>
> Amicalement,
That should be it. Please post updates as needed.
regards,
Ben
More information about the U-Boot
mailing list