[U-Boot] [PATCH] common: add a grepenv command

Kim Phillips kim.phillips at freescale.com
Fri Jul 16 20:42:52 CEST 2010


On Fri, 16 Jul 2010 11:27:03 +0200
Wolfgang Denk <wd at denx.de> wrote:

> Dear Kim Phillips,
> 
> In message <20100715221522.1dd4eecb.kim.phillips at freescale.com> you wrote:
> > u-boot environments, esp. when boards are shared across multiple users,
> > can get pretty large and time consuming to visually parse.
> > The grepenv command this patch adds can be used in lieu of printenv
> > to facilitate searching.  grepenv works like printenv but limits its output
> > only to environment strings (variable name and value pairs) that match the
> > user specified substring.
> 
> Thanks, but I will not apply thjis.
> 
> I'm in the process of resturcturing the whole environment handling.
> The new implementation will use a hash table for internal storage, so
> this code would no longer apply then.

it would still apply, in that the environment should still be greppable,
but, yes, if the internal structures are changed, this patch would need
updating, along the same lines as with printenv and friends.

> Please wait a bit for me to publish the new code, and then try to
> reimplement it in the new environment.

technically this should be allowed in, because it was submitted first
and it's need is overdue IMHO (I have already gotten off-list thanks
for this patch).  Subsequent patches need to honour valid patches
posted to the list first.

Having said that, would you like to send me your hash table patches?

Kim



More information about the U-Boot mailing list