[U-Boot] [PATCH] common: add a grepenv command
Wolfgang Denk
wd at denx.de
Fri Jul 16 21:12:28 CEST 2010
Dear Kim,
In message <20100716134252.b053e2dc.kim.phillips at freescale.com> you wrote:
>
> > I'm in the process of resturcturing the whole environment handling.
> > The new implementation will use a hash table for internal storage, so
> > this code would no longer apply then.
>
> it would still apply, in that the environment should still be greppable,
> but, yes, if the internal structures are changed, this patch would need
> updating, along the same lines as with printenv and friends.
I don;t see how you would grep the entries in a hash table - except by
walking through all entries, which works, but is slow. But then, the
new code will print the variable alphabetically sorted, so looking up
a setting will be much easier anyway :-)
> technically this should be allowed in, because it was submitted first
> and it's need is overdue IMHO (I have already gotten off-list thanks
> for this patch). Subsequent patches need to honour valid patches
> posted to the list first.
Yes, you are right. Let's put this patch on hold for now; eventually
we can have both this and the new env code.
> Having said that, would you like to send me your hash table patches?
I'm still working on fixes and cleanup. I intend to post the patches
before the MW closes, though (and provide a branch to pull from).
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
No man knows what true happiness is until he gets married. By then,
of course, its too late.
More information about the U-Boot
mailing list