[U-Boot] [PATCH v4 6/8] mpc5121: add support for PDM360NG board

[Anatolij Gustschin]

On Sun, 9 May 2010 11:01:45 +0300
Michael Zaidman <michael.zaidman at gmail.com> wrote:

> On Sat, Apr 24, 2010 at 8:27 PM, Anatolij Gustschin <agust at denx.de> wrote:
> > PDM360NG is a MPC5121E based board by ifm ecomatic gmbh.
> >
> 
> [snip]
> 
> +#define CONFIG_SYS_INIT_RAM_END                CONFIG_SYS_SRAM_SIZE
> /* End of area */
> +
> +#define CONFIG_SYS_GBL_DATA_SIZE       0x100   /* num bytes of initial data */
> +#define CONFIG_SYS_GBL_DATA_OFFSET     (CONFIG_SYS_INIT_RAM_END - \
> +                                        CONFIG_SYS_GBL_DATA_SIZE)
> +#define CONFIG_SYS_POST_WORD_ADDR      (CONFIG_SYS_GBL_DATA_OFFSET - 0x4)
> 
> The CONFIG_SYS_POST_WORD_ADDR is not defined correctly. The base
> address is absent.

This is true. This macro is slightly confusing and for some other
boards it actually means the post word offset. I should have
defined _POST_ADDR as (CONFIG_SYS_SRAM_BASE + CONFIG_SYS_POST_WORD_ADDR)
in .../mpc5121/common.c file. Since the post test on this board
runs quite late (in RAM and not before relocation), this bug
didn't show up. Thanks for reporting it!
 
> This will be fixed by POST cleanup consolidated patch anyway.

Thanks for this work!

Best regards,
Anatolij