[U-Boot] [PATCH V2 2/7] Adding more control to physical address mapping
Wolfgang Denk
wd at denx.de
Tue Sep 28 19:33:23 CEST 2010
Dear York Sun,
In message <1285691891-32700-2-git-send-email-yorksun at freescale.com> you wrote:
> A worker function __setup_ddr_tlbs() is introduced to implement more
> control on physical address mapping.
The __ name prefix has a special, reserved meaning. What is your
rationale for using it here?
> +unsigned int setup_ddr_tlbs(unsigned int memsize_in_meg)
> +{
> + return
> + __setup_ddr_tlbs(CONFIG_SYS_DDR_SDRAM_BASE, memsize_in_meg);
Remove line break.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The first thing we do is kill all the lawyers.
(Shakespeare. II Henry VI, Act IV, scene ii)
More information about the U-Boot
mailing list