[U-Boot] [PATCH] Provide pr_debug() and pr_info().

Wolfgang Denk wd at denx.de
Fri Apr 1 19:56:11 CEST 2011


Dear Alexander Holler,

In message <1301674331-7476-1-git-send-email-holler at ahsoftware.de> you wrote:
> Those are usefull for compatibility with the kernel.
> Remove the locally defined pr_debug() in atmel_mci.c.
> 
> Signed-off-by: Alexander Holler <holler at ahsoftware.de>
> ---
>  drivers/mmc/atmel_mci.c |    6 ------
>  include/common.h        |    4 ++++
>  2 files changed, 4 insertions(+), 6 deletions(-)

NAK.  This is just adding redundant overhead.  I don;t want to have
yet another incarnation of macros which already exist.

Either replace the code in drivers/mmc/atmel_mci.c by a simple

	#define pr_debug(fmt, args...) debug(fmt, ##args)

or convert the code that uses this reference.

And pr_info() is completrely redundant and not used anywhere.


If you really think that pr_debug() is so much better than debug(),
then convert ALL code to use that.  But I am not a friend of such a
change.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"When the only  tool  you  have  is  a  hammer,  you  tend  to  treat
everything as if it were a nail."                    - Abraham Maslow


More information about the U-Boot mailing list