[U-Boot] [PATCH] Provide pr_debug() and pr_info().

Alexander Holler holler at ahsoftware.de
Fri Apr 1 21:40:55 CEST 2011


Hello,

Am 01.04.2011 19:56, schrieb Wolfgang Denk:
> Dear Alexander Holler,
>
> In message<1301674331-7476-1-git-send-email-holler at ahsoftware.de>  you wrote:
>> Those are usefull for compatibility with the kernel.
>> Remove the locally defined pr_debug() in atmel_mci.c.
>>
>> Signed-off-by: Alexander Holler<holler at ahsoftware.de>
>> ---
>>   drivers/mmc/atmel_mci.c |    6 ------
>>   include/common.h        |    4 ++++
>>   2 files changed, 4 insertions(+), 6 deletions(-)
>
> NAK.  This is just adding redundant overhead.  I don;t want to have
> yet another incarnation of macros which already exist.
>
> Either replace the code in drivers/mmc/atmel_mci.c by a simple
>
> 	#define pr_debug(fmt, args...) debug(fmt, ##args)
>
> or convert the code that uses this reference.
>
> And pr_info() is completrely redundant and not used anywhere.
>
>
> If you really think that pr_debug() is so much better than debug(),
> then convert ALL code to use that.  But I am not a friend of such a
> change.

Than just forget this patch and someone else should add those macros to 
future imports of sources from the kernel. At least I will now do so.

Regards,

Alexander Holler




More information about the U-Boot mailing list