[U-Boot] [PATCH v4 03/23] keymile: Fix Coding style issues for keymile boards.
Wolfgang Denk
wd at denx.de
Sat Apr 2 00:51:48 CEST 2011
Dear Kim Phillips,
In message <20110401173209.55577aea.kim.phillips at freescale.com> you wrote:
> On Fri, 1 Apr 2011 09:16:15 +0200
> Heiko Schocher <hs at denx.de> wrote:
>
> > - use I/O accessors
> > -> For accessing the FPGA therefore a struct km_bec_fpga
> > is introduced.
> > - no longer externs needed
> > - to defines, that only select functions, don;t assign a
> > numeric value
> > - Codingstyle changes to prevent checkpatch errors/warnings
> >
> > Signed-off-by: Heiko Schocher <hs at denx.de>
> > cc: Kim Phillips <kim.phillips at freescale.com>
> > cc: Holger Brunck <holger.brunck at keymile.com>
> > cc: Wolfgang Denk <wd at denx.de>
> > cc: Detlev Zundel <dzu at denx.de>
> > cc: Valentin Longchamp <valentin.longchamp at keymile.com>
> > cc: Prafulla Wadaskar <prafulla at marvell.com>
> > ---
>
> Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
Why do you send a "Signed-off-by" here?
Did you mean "Acked-by:" ?
Signed-off-by "certifies that you wrote it or otherwise have the right
to pass it on as a open-source patch." However, you have not been
anywhere in the queue of creating or forwarding these patches?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I express preference for a chronological sequence of events which
precludes a violence. - Terry Pratchett, _The Dark Side of the Sun_
More information about the U-Boot
mailing list