[U-Boot] [PATCH v4 03/23] keymile: Fix Coding style issues for keymile boards.

Kim Phillips kim.phillips at freescale.com
Sat Apr 2 01:17:51 CEST 2011


On Sat, 2 Apr 2011 00:51:48 +0200
Wolfgang Denk <wd at denx.de> wrote:

> Dear Kim Phillips,
> 
> In message <20110401173209.55577aea.kim.phillips at freescale.com> you wrote:
> > On Fri, 1 Apr 2011 09:16:15 +0200
> > Heiko Schocher <hs at denx.de> wrote:
> > 
> > > - use I/O accessors
> > >   -> For accessing the FPGA therefore a struct km_bec_fpga
> > >      is introduced.
> > > - no longer externs needed
> > > - to defines, that only select functions, don;t assign a
> > >   numeric value
> > > - Codingstyle changes to prevent checkpatch errors/warnings
> > > 
> > > Signed-off-by: Heiko Schocher <hs at denx.de>
> > > cc: Kim Phillips <kim.phillips at freescale.com>
> > > cc: Holger Brunck <holger.brunck at keymile.com>
> > > cc: Wolfgang Denk <wd at denx.de>
> > > cc: Detlev Zundel <dzu at denx.de>
> > > cc: Valentin Longchamp <valentin.longchamp at keymile.com>
> > > cc: Prafulla Wadaskar <prafulla at marvell.com>
> > > ---
> > 
> > Signed-off-by: Kim Phillips <kim.phillips at freescale.com>
> 
> Why do you send a "Signed-off-by" here?
> 
> Did you mean "Acked-by:" ?
> 
> Signed-off-by "certifies that you wrote it or otherwise have the right
> to pass it on as a open-source patch."  However, you have not been
> anywhere in the queue of creating or forwarding these patches?

as 83xx maintainer, I sign off on all patches committed to the mpc83xx
tree, which are subsequently 'forwarded' to the main u-boot tree.  This
particular case is no different, except the 83xx patches here are too
intertwined with other, non-83xx ones.  So to facilitate the process, I
sign them off on-list such that they can be applied as-is to the
main u-boot tree.

hth,

Kim



More information about the U-Boot mailing list