[U-Boot] [PATCH] [v4] powerpc: clean up DIU macro definitions for Freescale reference boards

Wolfgang Denk wd at denx.de
Tue Apr 5 12:58:12 CEST 2011


Dear Timur Tabi,

In message <1297811359-28389-1-git-send-email-timur at freescale.com> you wrote:
> Clean up the macro defintions used to enable DIU (video) support on the
> MPC8610HPCD and the MPC5121ADS so that they look more like the P1022DS,
> which is newer.  Add software cursor support to all three boards.

Software cursor support should be split off into a separate patch.
And CONFIG_VIDEO_SW_CURSOR needs to be documented.

> Also document the CONFIG_FSL_DIU_FB in the README.
...
> +		The DIU driver will look for the 'monitor' environment variable,
> +		and if defined, enable the DIU as a console during boot.  This
> +		variable should be set to one of these values:
> +
> +			'0'	Output video to the DVI connector
> +			'1'	Output video to the LVDS connector
> +			'2'	Output video to the Dual-Link LVDS connector

Maybe it would be more user-friendly if we used easy to remember names
instead of some magic numbers, like "dvi", "lvds" resp. "dlvds" (or
whatever) ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I used to be indecisive, now I'm not sure.


More information about the U-Boot mailing list