[U-Boot] [PATCH v3 5/8] Create PHY Lib for U-Boot

Wolfgang Denk wd at denx.de
Fri Apr 8 06:34:32 CEST 2011


Dear Andy Fleming,

In message <1302231367-25321-6-git-send-email-afleming at freescale.com> you wrote:
> Extends the mii_dev structure to participate in a full-blown MDIO and
> PHY driver scheme.  The mii_dev structure and miiphy calls are modified
> in such a way to allow the original mii command and miiphy
> infrastructure to work as before, but also to support a new set of APIs
> which allow (among other things) sharing of PHY driver code and 10G support
> 
> The mii command will continue to support normal PHY management functions
> (Clause 22 of 802.3), but will not be changed to support 10G
> (Clause 45).
> 
> The basic design is similar to PHY Lib from Linux, but simplified for
> U-Boot's network and driver infrastructure.
...
> v3:
> * Made mii_dev->name an array, and added a warning for if someone ever
>   tries to register a bus with more than 32 characters
> * Fixed some minor formatting issues
> * Changed phy_read and phy_write to be inline functions in phy.h
> * Moved mii_dev definition to phy.h (necessary for phy_read/phy_write)
> * Split out 10G support so it's only built if CONFIG_PHYLIB_10G is defined
> * Removed constants stolen from linux, and added linux/mdio.h and
>   linux/ethtool.h

I understand this is still code copied from Linux, right?

I already asked this before: can you please merk in the commit message
where exactly code has been copied from, and which?  We need exact
reference, with exact kernel version / commit ID.

Please see bullet 4 at
http://www.denx.de/wiki/view/U-Boot/Patches#Attributing_Code_Copyrights_Sign

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Every program has at least one bug and can be shortened by  at  least
one instruction - from which, by induction, one can deduce that every
program can be reduced to one instruction which doesn't work.


More information about the U-Boot mailing list