[U-Boot] [RFC] mpc83xx: add config options to spd_sdram

[York Sun]

On Fri, 2011-04-08 at 18:29 +0200, Andre Schwarz wrote:
> York,
> > On Fri, 2011-04-08 at 09:41 +0200, Andre Schwarz wrote:
> >>> I am sorry I totally ignored the subject with mpc83xx. I was thinking of
> >>> mpc85xx.
> >> ok - no "new" code for 83xx then.
> >>> You are right the old code is in spd_sdram.c and it is still in use for
> >>> mpc83xx. Unless to adjust the code, there is no board specific file.
> >>>
> >> Are you willing to accept some changes to spd_sdram.c or will I have
> >> another out-of-tree board  ?
> >>
> >> What we need is :
> >>
> >> - more configurable settings like driver strength, cpo and odt values.
> >> - Reading SPD data from an arbitrary i2c eeprom.
> >>
> >> What's so bad about my proposal ?
> >> Please let me know so that I'm able to improve.
> >>
> > I welcome the change to use the new code since the feature you asked is
> > already there.
> sorry, but I'm not sure if I understand this correctly.
> 
> What I need is some minor non-intrusive changes to 83xx-specific file 
> spd_sdram.c because it is the most straightforward solution with *no* 
> impact on code size or other existing boards. So: The feature I ask for 
> is *not* already there.
> 
> What I definitely won't do is use the "new" fsl ddr code in mpc8xxx/ddr 
> because it completely lacks 83xx support.
> So: The feature I ask for is there but my CPU family is not supported.
> IMHO the "new" code is total overkill for 83xx.
> 

It would be easier to maintain one set of code. But if the change you
need is relatively small to the old code and doesn't have negative
impact on other boards, go ahead to post the patch.

York