[U-Boot] [PATCH 3/6] Env and lds file clean up for ColdFire M5445x and M547x/8x boards.

Wolfgang Denk wd at denx.de
Tue Apr 12 12:13:34 CEST 2011


Dear Jason Jin,

In message <1302597610-15646-4-git-send-email-Jason.jin at freescale.com> you wrote:
> Move the environment outside the u-boot image, leave more
>  space for the text to avoid the possible PC truncate issue.
> 
>  The lds file for ColdFire need to clean up since commit
>  6d8962e814c15807dd6ac5757904be2a02d187b8 'Switch from archive
>  libraries to partial linking'.
...
>  /*
>   * Configuration for environment
> - * Environment is embedded in u-boot in the second sector of the flash
> + * Environment is not embedded in u-boot. First time runing may have env crc error warnig
> + * if there are no correct environment on the flash.

Line too long.

> +#define CONFIG_SYS_MALLOC_LEN		(256 << 10)	/* Reserve 256 kB for malloc() */

Ditto. Please fix globally!


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Documentation is like sex: when it is good, it is  very,  very  good;
and when it is bad, it is better than nothing.         - Dick Brandon


More information about the U-Boot mailing list