[U-Boot] [PATCH 2/6] Fix the CPP flags for toolchain 4.4.1 on ColdFire boards.

[Wolfgang Denk]

Dear Jason Jin,

In message <1302597610-15646-3-git-send-email-Jason.jin at freescale.com> you wrote:
> The original comparing the 4.1 with gcc --version will assume
> the toolchain 4.4.1 as toolchain 4.1 and setup wrong CPP flags.
> 
> Signed-off-by: Lu Jingchang <b35083 at freescale.com>
> Signed-off-by: Jason Jin <Jason.jin at freescale.com>

It is IMO a bad idea to base option settings on specific strings in
the compiler version.  Cannot you test if the respective options are
supported by a specific compiler, as we do in so many other places?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
My challenge to the goto-less programmer  is  to  recode  tcp_input()
without any gotos ... without any loss of efficiency (there has to be
a catch).                                             - W. R. Stevens