[U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet

Mike Frysinger vapier at gentoo.org
Wed Apr 13 05:48:22 CEST 2011


On Tuesday, April 12, 2011 20:46:09 Simon Glass wrote:
> --- a/include/net.h
> +++ b/include/net.h
> +/* Tftp Server IP addr (0 = unknown)*/
> +extern IPaddr_t		NetTftpServerIP;

doesnt seem to belong in this patch.  guess it bled in from another ?

> --- a/net/eth.c
> +++ b/net/eth.c
> @@ -254,31 +287,12 @@
>  				eth_current = dev;
>  				puts (" [PRIME]");
>  			}
> -
>  			if (strchr(dev->name, ' '))
> -				puts("\nWarning: eth device name has a space!\n");
> +				puts("\nWarning: eth device name has a "
> +					"space!\n");

please dont change unrelated things.  that newline should be there, and this 
string shouldnt be broken up.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110412/f8062dee/attachment.pgp 


More information about the U-Boot mailing list