[U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet

Albert ARIBAUD albert.u.boot at aribaud.net
Wed Apr 13 22:23:20 CEST 2011


Le 13/04/2011 05:48, Mike Frysinger a écrit :

>>   			if (strchr(dev->name, ' '))
>> -				puts("\nWarning: eth device name has a space!\n");
>> +				puts("\nWarning: eth device name has a "
>> +					"space!\n");
>
> please dont change unrelated things.  that newline should be there, and this
> string shouldnt be broken up.

Technically it is not. A C string constant can be made of several 
quote-delimited string literals separated by whitespace -- so this 
change is a no-op, and does not remove any newline btw. I suspect the 
change is to keep checkpatch.pl happy about the line length.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list