[U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet

[Simon Glass]

On Wed, Apr 13, 2011 at 1:23 PM, Albert ARIBAUD
<albert.u.boot at aribaud.net> wrote:
> Le 13/04/2011 05:48, Mike Frysinger a écrit :
>
>>>                      if (strchr(dev->name, ' '))
>>> -                            puts("\nWarning: eth device name has a space!\n");
>>> +                            puts("\nWarning: eth device name has a "
>>> +                                    "space!\n");
>>
>> please dont change unrelated things.  that newline should be there, and this
>> string shouldnt be broken up.
>
> Technically it is not. A C string constant can be made of several
> quote-delimited string literals separated by whitespace -- so this
> change is a no-op, and does not remove any newline btw. I suspect the
> change is to keep checkpatch.pl happy about the line length.

Yes it was, but on-line reviewers are noisier than checkpatch so have
changed it. Also I was actually reverting a previous change so there
is no need for my change at all. But thank you for your kind
understanding.

I do find it quite confusing adding code which fits with U-Boot's
coding style to a file which doesn't :-)

Regards,
Simon

>
> Amicalement,
> --
> Albert.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>