[U-Boot] [PATCH v2 2/5] Add Ethernet hardware MAC address framework to usbnet

Mike Frysinger vapier at gentoo.org
Wed Apr 13 23:05:59 CEST 2011


On Wednesday, April 13, 2011 16:23:20 Albert ARIBAUD wrote:
> Le 13/04/2011 05:48, Mike Frysinger a écrit :
> >>   			if (strchr(dev->name, ' '))
> >> 
> >> -				puts("\nWarning: eth device name has a space!\n");
> >> +				puts("\nWarning: eth device name has a "
> >> +					"space!\n");
> > 
> > please dont change unrelated things.  that newline should be there, and
> > this string shouldnt be broken up.
> 
> Technically it is not. A C string constant can be made of several
> quote-delimited string literals separated by whitespace -- so this
> change is a no-op, and does not remove any newline btw. I suspect the
> change is to keep checkpatch.pl happy about the line length.

you truncated my quote which changes things significantly.  i wasnt talking 
about the string when i said newline.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110413/5baa3e96/attachment.pgp 


More information about the U-Boot mailing list