[U-Boot] [PATCH] Fix bad padding of bootp request packet

Wolfgang Denk wd at denx.de
Wed Apr 13 22:25:34 CEST 2011


Dear Simon Glass,

In message <1296687808-10086-1-git-send-email-sjg at chromium.org> you wrote:
> This seems to pad to one byte longer than required
> 
> Change-Id: I86a888a9f5f27356e260c0457d92468d5923a756
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>  net/bootp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bootp.c b/net/bootp.c
> index 1a71786..87b027e 100644
> --- a/net/bootp.c
> +++ b/net/bootp.c
> @@ -464,7 +464,7 @@ static int DhcpExtended (u8 * e, int message_type, IPaddr_t ServerID, IPaddr_t R
>  
>  	/* Pad to minimal length */
>  #ifdef	CONFIG_DHCP_MIN_EXT_LEN
> -	while ((e - start) <= CONFIG_DHCP_MIN_EXT_LEN)
> +	while ((e - start) < CONFIG_DHCP_MIN_EXT_LEN)
>  		*e++ = 0;
>  #endif

Applied (after removing the Change-Id line from the commit message;
hope this is OK).

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have a very small mind and must live with it.    -- Edsger Dijkstra


More information about the U-Boot mailing list