[U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

[Mike Frysinger]

On Wednesday, April 13, 2011 14:47:10 Simon Glass wrote:
> On Tue, Apr 12, 2011 at 8:44 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> > On Tuesday, April 12, 2011 20:46:08 Simon Glass wrote:
> >> +/*
> >> + * SMSC probing functions
> >> + */
> >> +void smsc95xx_eth_before_probe(void)
> >> +{
> >> +     curr_eth_dev = 0;
> >> +}
> > 
> > curr_eth_dev is declared static which means it starts off with a value of
> > 0. when does before_probe get called ?  just once ever during the
> > execution of u- boot ?  i guess this func should get tossed if that's
> > the case.
> 
> It is called on a 'usb start'. I think we should keep it so people can
> call this repeatedly without problems.

as long as the devices created in between are also punted, this should be 
fine.  i was thinking of this case as you dont want:
 - usb start
 - probe some usb net devices (get usbnet0 and usbnet1)
 - usb start
 - previous usbnet0/usbnet1 still exist, and the counter has been reset to 0 
so the new devices start back at usbnet0

if there's something in the bigger picture that takes care of this already, 
then this is probably fine.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110413/072e80c6/attachment.pgp