[U-Boot] [PATCH v2 1/5] Add support for SMSC95XX USB 2.0 10/100MBit Ethernet Adapter

[Wolfgang Denk]

Dear Simon Glass,

In message <BANLkTi=oUMockMG45vV6jo9WpMe+OQJxoA at mail.gmail.com> you wrote:
>
> >> Yes, it is important to shut down devices. =A0Especially with USB
> >> devices.
...
> Actually on second thoughts this actually conflicts which what you are
> telling me on the rejected patch.

Not really.

> If the Ethernet adapter shuts down when halt() is called, then
> presumably it will lose the link. Then when a tftp  comes along, there
> is a delay while it re-establishes the link.
> 
> So we have:
> 
> bootp   (calls init, send, recv, halt)
> tftp     (calls init, send, recv, halt)
> 
> If halt takes the link down then there will be a delay, which is what
> my rejected patch was trying to work around.
> 
> So I think either halt should leave the link up, or we need a way to
> not call init/halt all the time.

The second is probably true.  See the discussion we had about this
when Stefano Babic implemented netconsole over ethernet over USB.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
panic: kernel trap (ignored)