[U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

[Wolfgang Denk]

Dear Mike Frysinger,

In message <201104150453.21441.vapier at gentoo.org> you wrote:
>
> > > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:
> > >>  #if !defined(CONFIG_ENV_IS_IN_EEPROM)        && \
> > >> -    !defined(CONFIG_ENV_IS_IN_FLASH) && \
> > >> +     !defined(CONFIG_ENV_IS_IN_FLASH)        && \
> > > 
> > > not sure this one hunk is desirable, but the rest are fine
> > > -mike
> > 
> > Do you mean the replacement with space to ident?
> > 
> > According to the 2.6.38.1's checkpatch, it reported:
> > WARNING: please, no spaces at the start of a line
>
> this particular check has already been posted upstream as generally causing
> more harm than good.  but getting checkpatch fixed often feels glacial.
>
> up to Wolfgang how he feels about ifdef indentation

In this specific case of #ifdef indentation I feel that the original
form (which causes checkpatch warnings) is actually easier to read, so
I tend to keep it.  But I am aware that this is inconsequent as we ask
for "indentation by TAB only" everywhere else.

So I'm really torn - if it was for myself only I would not hesitate to
leave this part as is, but I realize that quite a number of users have
already complained about the unclear rules and exceptions we make with
the coding style requirements, and some actually threw in the sponge
because of that.

I'm afraid I'm not much of help here.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Alles Gescheite ist schon gedacht worden, man muß nur versuchen,
es noch einmal zu denken.          -- Goethe, Maximen und Reflexionen