[U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch

[Mike Frysinger]

On Friday, April 15, 2011 06:09:12 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > > On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:
> > > >>  #if !defined(CONFIG_ENV_IS_IN_EEPROM)        && \
> > > >> 
> > > >> -    !defined(CONFIG_ENV_IS_IN_FLASH) && \
> > > >> +     !defined(CONFIG_ENV_IS_IN_FLASH)        && \
> > > > 
> > > > not sure this one hunk is desirable, but the rest are fine
> > > 
> > > Do you mean the replacement with space to ident?
> > > 
> > > According to the 2.6.38.1's checkpatch, it reported:
> > > WARNING: please, no spaces at the start of a line
> > 
> > this particular check has already been posted upstream as generally
> > causing more harm than good.  but getting checkpatch fixed often feels
> > glacial.
> > 
> > up to Wolfgang how he feels about ifdef indentation
> 
> In this specific case of #ifdef indentation I feel that the original
> form (which causes checkpatch warnings) is actually easier to read, so
> I tend to keep it.  But I am aware that this is inconsequent as we ask
> for "indentation by TAB only" everywhere else.
> 
> So I'm really torn - if it was for myself only I would not hesitate to
> leave this part as is, but I realize that quite a number of users have
> already complained about the unclear rules and exceptions we make with
> the coding style requirements, and some actually threw in the sponge
> because of that.

well, this is a case where i would say a soft rule is OK -- i.e. allow both 
options and let the active maintainer of the code in question decide.  i too 
prefer the current style as i find it easier to read, but if someone 
maintaining code i never work on wants to be strict about tabs, then it's no 
sweat off my back.

so, not to dupe another thread, but i'd say "use common sense".  but that 
probably too isn't consistent/clear enough for many people.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110415/97f451b9/attachment.pgp