[U-Boot] [PATCH] cmd_nvedit.c: clean up with checkpatch
Graeme Russ
graeme.russ at gmail.com
Sat Apr 16 09:07:06 CEST 2011
On 16/04/11 16:22, Albert ARIBAUD wrote:
> Hi all,
>
> Le 15/04/2011 12:09, Wolfgang Denk a écrit :
>> Dear Mike Frysinger,
>>
>> In message<201104150453.21441.vapier at gentoo.org> you wrote:
>>>
>>>>> On Friday, April 15, 2011 03:02:58 Macpaul Lin wrote:
>>>>>> #if !defined(CONFIG_ENV_IS_IN_EEPROM)&& \
>>>>>> - !defined(CONFIG_ENV_IS_IN_FLASH)&& \
>>>>>> + !defined(CONFIG_ENV_IS_IN_FLASH)&& \
>>>>>
[snip]
>
> If the goal is to have the !defined aligned, then maybe a solution here
> would be toput a tab rather than a space after the #if?
>
I agree - Aligned looks cleaner and easier to read (especially if the logic
is multi-levelled) and shutting up checkpatch by using a tab rather than a
space is an easy solution
But, fwiw, once the patch is applied and everything is nicely aligned and
reads well, who's going to care that checkpatch complained?
Regards,
Graeme
More information about the U-Boot
mailing list