[U-Boot] [PATCH-V2 2/2] at91: reworked support for otc570 board

[Daniel Gorsulowski]

Hello Reinhard,

Reinhard Meyer wrote:
> Am 18.04.2011 16:15, schrieb Daniel Gorsulowski:
>> The otc570 board support was broken. Within this opportunity, I completely
>> reworked the board files.
>>
>> Signed-off-by: Daniel Gorsulowski <Daniel.Gorsulowski at esd.eu>
>> ---
>>
>> This patch is based on u-boot-atmel/rework101229 branch (minus the last 5
>> patches) plus the 'at91: fixed at91sam9263 system file' patch in
>> u-boot-atmel/next branch.
>>
>> V2: -fixed commit description
>>
>>  board/esd/otc570/config.mk |    1 -
>>  board/esd/otc570/otc570.c  |  106 ++++++++++--------
>>  boards.cfg                 |    3 +-
>>  include/configs/otc570.h   |  265 +++++++++++++++++++++++++-------------------
>>  4 files changed, 211 insertions(+), 164 deletions(-)
>>  delete mode 100644 board/esd/otc570/config.mk
> 
> This patch had several places with <space><tab> or <start of line><space>.
> 
> I removed them manually. Please, next time run your patches through
> <linux>/scripts/checkpatch.pl. Thanks.

Sorry, but I checked my patches by checkpatch.pl. Maybe you can explain
me, what I did wrong?

danielg at debby:~/git/u-boot-atmel$
../linux/linux-2.6/scripts/checkpatch.pl
0002-at91-reworked-support-for-otc570-board.patch
WARNING: Use #include <linux/io.h> instead of <asm/io.h>
#48: FILE: board/esd/otc570/otc570.c:30:
+#include <asm/io.h>

ERROR: Macros with complex values should be enclosed in parenthesis
#578: FILE: include/configs/otc570.h:209:
+# define CONFIG_SYS_NAND_ENABLE_PIN            AT91_PIO_PORTD, 15

ERROR: Macros with complex values should be enclosed in parenthesis
#579: FILE: include/configs/otc570.h:210:
+# define CONFIG_SYS_NAND_READY_PIN             AT91_PIO_PORTA, 22

total: 2 errors, 1 warnings, 610 lines checked

0002-at91-reworked-support-for-otc570-board.patch has style problems,
please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

> 
> Applied to u-boot-atmel/next.

Thank you!

> 
> Best Regards,
> 
> Reinhard
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 
> 
> 

-- 
Mit freundlichen Grüßen
Daniel Gorsulowski

-------------------------------------------------------------------------
B.Eng. Daniel Gorsulowski
System-Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Telefon: 0511-37298-192 - Fax: 0511-37298-68
Bitte besuchen Sie uns im Internet unter http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Geschäftsführer: Klaus Detering
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------