[U-Boot] [PATCH V5 2/2] MX53: support for freescale MX53LOCO board

[Stefano Babic]

On 04/20/2011 12:47 PM, Jason Liu wrote:

> +int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> +{
> +	struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> +
> +	if (cfg->esdhc_base == MMC_SDHC1_BASE_ADDR)
> +		*cd = mxc_gpio_get(77); /*GPIO3_13*/
> +	else
> +		*cd = mxc_gpio_get(75); /*GPIO3_11*/
> +
> +	return 0;
> +}

Rereading the thread regarding this board I see there is an open
question issued by Wolfgang about this code, if accessors should be used
in this case. IMHO the code is correct, using the GPIO get function to
acquire the current value of a pin. Wolfgang, is it enough to answer
your question ? Do you see an open issue ?

> +/* PMIC Configs */
> +#define CONFIG_FSL_PMIC
> +#define CONFIG_FSL_PMIC_I2C
> +#define CONFIG_SYS_FSL_PMIC_I2C_ADDR    8

If I am not confused, this setup is not valid as you already sent a
patchset to drop these lines and adding support for the DA9053 pmic.

	PMIC: Add dialog pmic support
	MX53: loco: Add power init support

As this patchset is based on the LOCO patch (this one), and it does not
apply anymore, please drop these lines and rebase your patches to add
pmic support on the actual state of the current patch.
IMHO it should be better if you resend them as a single patchset, as
they are strictly related, merging "Add power init support" inside this
patch.


> +#define CONFIG_SYS_MEMTEST_START       0x70000000
> +#define CONFIG_SYS_MEMTEST_END         0x70010000

There is still an open question about this range. Can you answer to
Wolfgang's question ?

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================