[U-Boot] [PATCH V5 2/2] MX53: support for freescale MX53LOCO board

[Wolfgang Denk]

Dear Stefano Babic,

In message <4DB06CBE.8050803 at denx.de> you wrote:
> On 04/20/2011 12:47 PM, Jason Liu wrote:
> 
> > +int board_mmc_getcd(u8 *cd, struct mmc *mmc)
> > +{
> > +	struct fsl_esdhc_cfg *cfg = (struct fsl_esdhc_cfg *)mmc->priv;
> > +
> > +	if (cfg->esdhc_base == MMC_SDHC1_BASE_ADDR)
> > +		*cd = mxc_gpio_get(77); /*GPIO3_13*/
> > +	else
> > +		*cd = mxc_gpio_get(75); /*GPIO3_11*/
> > +
> > +	return 0;
> > +}
> 
> Rereading the thread regarding this board I see there is an open
> question issued by Wolfgang about this code, if accessors should be used
> in this case. IMHO the code is correct, using the GPIO get function to
> acquire the current value of a pin. Wolfgang, is it enough to answer
> your question ? Do you see an open issue ?

I was just asking.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When all else fails, read the instructions.