[U-Boot] [PATCH 1/2][v2] powerpc: eSPI and eSPI controller support

[Kumar Gala]

On Apr 21, 2011, at 4:20 PM, Mike Frysinger wrote:

> On Thu, Apr 21, 2011 at 2:13 PM, Kumar Gala wrote:
>> On Apr 21, 2011, at 12:10 PM, Mike Frysinger wrote:
>>> On Thu, Apr 21, 2011 at 2:04 AM, Shaohui Xie wrote:
>>>> --- a/include/spi.h
>>>> +++ b/include/spi.h
>>>> /* Controller-specific definitions: */
>>>> 
>>>> /* CONFIG_HARD_SPI triggers SPI bus initialization in PowerPC */
>>>> -#ifdef CONFIG_MPC8XXX_SPI
>>>> +#if defined(CONFIG_MPC8XXX_SPI) || defined(CONFIG_FSL_ESPI)
>>>> # ifndef CONFIG_HARD_SPI
>>>> #  define CONFIG_HARD_SPI
>>>> # endif
>>> 
>>> i cant see why this PowerPC-specific code needs to be in the common
>>> spi.h.  why cant this live in a PowerPC header like asm/config.h ?  (i
>>> know this code predates asm/config.h)
>> 
>> If the rest of the patch looks fine we can move this into asm/config.h
>> 
>> There are a bunch of board patches I'd like to get in that depend on the base SPI driver being in tree.
> 
> i dont run spi drivers through my tree, so generally if the arch
> maintainer is happy with it, it's up to them to merge it.  i watch
> over the spi core and the spi flash pieces, and sometimes give
> feedback on the specific spi drivers.
> -mike

Ok, I'll take it via my tree, but would like your ack on the patch.

- k