[U-Boot] [PATCH 1/2][v2] powerpc: eSPI and eSPI controller support

Xie Shaohui-B21989 B21989 at freescale.com
Fri Apr 22 07:01:01 CEST 2011





>-----Original Message-----
>From: vapierfilter at gmail.com [mailto:vapierfilter at gmail.com] On Behalf Of
>Mike Frysinger
>Sent: Friday, April 22, 2011 1:10 AM
>To: Xie Shaohui-B21989
>Cc: u-boot at lists.denx.de; Gala Kumar-B11780; Zang Roy-R61911; Hu Mingkai-
>B21284
>Subject: Re: [PATCH 1/2][v2] powerpc: eSPI and eSPI controller support
>
>On Thu, Apr 21, 2011 at 2:04 AM, Shaohui Xie wrote:
>> --- a/include/spi.h
>> +++ b/include/spi.h
>>  /* Controller-specific definitions: */
>>
>>  /* CONFIG_HARD_SPI triggers SPI bus initialization in PowerPC */
>> -#ifdef CONFIG_MPC8XXX_SPI
>> +#if defined(CONFIG_MPC8XXX_SPI) || defined(CONFIG_FSL_ESPI)
>>  # ifndef CONFIG_HARD_SPI
>>  #  define CONFIG_HARD_SPI
>>  # endif
>
>i cant see why this PowerPC-specific code needs to be in the common spi.h.
>why cant this live in a PowerPC header like asm/config.h ?  (i know this
>code predates asm/config.h) -mike
[Xie Shaohui] OK, I'll move these codes to asm/config.h


Best Regards, 
Shaohui Xie 




More information about the U-Boot mailing list