[U-Boot] [PATCH 07/11] Allow setting CONFIG_NR_DRAM_BANKS to a larger value

[Wolfgang Denk]

Dear rogan at dawes.za.net,

In message <1300435500-4909-8-git-send-email-rogan at dawes.za.net> you wrote:
> From: rogan at dawes.za.net <rogan at dawes.za.net>
> 
> This allows us to match the exact behaviour of the vendor U-boot in the kernel boot logs

Please note that the behaviour of some out of tree port is not exactly
a criterion for how U-Boot should behave.

Could you please describe what exactly you consider wrong witrh the
current implementation?

> --- a/common/memsize.c
> +++ b/common/memsize.c
> @@ -46,6 +46,9 @@ long get_ram_size(volatile long *base, long maxsize)
>  	long           size;
>  	int            i = 0;
>  
> +	if (base == -1)
> +		return 0;
> +

You should never call get_ram_size() with invalid parameters in the
first place.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Operating-system software is the program that  orchestrates  all  the
basic functions of a computer.
- The Wall Street Journal, Tuesday, September 15, 1987, page 40