[U-Boot] [PATCH 09/11] Support passing a Marvell-specific ATAG

Wolfgang Denk wd at denx.de
Mon Apr 25 23:43:15 CEST 2011


Dear rogan at dawes.za.net,

In message <1300435500-4909-10-git-send-email-rogan at dawes.za.net> you wrote:
> From: Rogan Dawes <rogan at dawes.za.net>
> 
> ---
>  arch/arm/include/asm/setup.h |   18 ++++++++++++++++++
>  arch/arm/lib/bootm.c         |   30 ++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+), 0 deletions(-)
...
> +/* Marvell specific information
> + * requred for compatability with vendor kernels
> + */

Incorrect multiline comment style.

> +#define ATAG_MV_UBOOT   0x41000403
> + 
> +struct tag_mv_uboot {
> +	u32 uboot_version;
> +	u32 tclk;
> +	u32 sysclk;
> +	u32 isUsbHost;
> +	u32 overEthAddr;
> +};

NAK for now.  Please resubmit after this ATAG has been accepted to the
mainline Linux kernel tree.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't put off for tomorrow what you can  do  today,  because  if  you
enjoy it today you can do it again tomorrow.


More information about the U-Boot mailing list