[U-Boot] [PATCH v3 4/4] ARMV7: OMAP3: Add support for Comelit DIG297 board

[Wolfgang Denk]

Dear Luca Ceresoli,

In message <4DA2B9FE.20408 at comelit.it> you wrote:
>
> > Note that arch/arm/cpu/armv7/omap3/mem.c is also the only file in the
> > whole U-Boot source tree which references these variables:
> >
> > ->  egrep -lR 'boot_flash_base|boot_flash_off|boot_flash_sec|boot_flash_type' *
> > arch/arm/cpu/armv7/omap3/mem.c
> > include/configs/am3517_evm.h
> > include/configs/devkit8000.h
> > include/configs/omap3_beagle.h
> > include/configs/cm_t35.h
> > include/configs/omap3_pandora.h
> > include/configs/omap3_sdp3430.h
> > include/configs/omap3_zoom1.h
> > include/configs/omap3_zoom2.h
> > include/configs/omap3_overo.h
> > include/configs/omap3_evm.h
> 
> Would you please read points c. and d. of my e-mail?

I did.  And I still cannot see why we must use variables declared as
extern in the board config files for this purpose.  Move the variable
declaration to the only file where they ever get used, change them
into "static" while doing this, and use preprocessor macros for the
rest like all other boards are doing it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
EMACS belongs in <sys/errno.h>: Editor too big!